Adds integration test for falco #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiubelu
force-pushed
the
adds-integration-test
branch
3 times, most recently
from
7f69c39 to
78a866a
Compare
|
please resolve the conflict I caused :) |
bschimke95
approved these changes
Oct 1, 2024
| f"{constants.K8S_DAEMONSET}/falco", | ||
| "--", | ||
| # TODO(claudiub): We're currently building with rockcraft 1.3.0. | ||
| # In rockcraft 1.3.1, pebble has moved to /usr/bin/pebble. |
There was a problem hiding this comment.
lol, this does not sound like a patch change to me - thanks Pebble
claudiubelu
force-pushed
the
adds-integration-test
branch
from
78a866a to
1ac24be
Compare
After deploying falco through the helm chart, we're deploying an event generator. After it finishes, falco should have detected its activities and it should have logged in its stdout some warnings.
claudiubelu
force-pushed
the
adds-integration-test
branch
from
1ac24be to
ed77a3f
Compare
|
Rebased, made an amend, simplifying the helm chart command function, but it depends on this PR merging first: canonical/k8s-test-harness#33 |
"Only those with write access to this repository can merge pull requests." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying falco through the helm chart, we're deploying an event generator. After it finishes, falco should have detected its activities and it should have logged in its stdout some warnings.
Depends-On: canonical/k8s-test-harness#33